Added endorseEnabled for admin group settings #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initialization and view settings
HeidiTao
requested review from
alx-zhu,
John-Crawshaw,
Victor-Crawshaw and
sherryzhuge1
HeidiTao
changed the title
Pull Request Test Coverage Report for Build 11265257926Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Victor-Crawshaw
added
Endorse
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endorseEnabled as a new field for the Groups module, and added checkbox to admin group settings.
Relevant updated files include:
src/groups/data.js: add the field; set null and undefined values to default (1=true)src/groups/create.js: add the new field to group datasrc/groups/update.js: cast values as boolpublic/src/admin/manage/group.js: include endorsement checkbox value when admin updates group settingssrc/views/admin/manage/group.tpl: allow checkbox to show up at frontendpublic/openapi/read/admin/manage/groups.yaml: update variables with typespublic/openapi/components/schemas/GroupObject.yaml: update variables with typespublic/openapi/read/groups.yaml: update variables with typesResolves #16